Messages in this thread | | | Subject | Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits | From | Eric Dumazet <> | Date | Fri, 30 Mar 2012 20:56:15 +0200 |
| |
On Fri, 2012-03-30 at 17:08 +0200, Jan Seiffert wrote: > The function is renamed to make it a little more clear what it does. > It is not added to any .h because it is not for general consumption, only for > bpf internal use (and so by the jits). > > Signed-of-by: Jan Seiffert <kaffeemonster@googlemail.com> >
Missing "---" line separator (check Documentation/SubmittingPatches line 490)
You can check http://patchwork.ozlabs.org/patch/149683/ and see there is a problem, compared to http://patchwork.ozlabs.org/patch/149441/ for example
> --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -40,8 +40,12 @@ > #include <linux/reciprocal_div.h> > #include <linux/ratelimit.h> > > -/* No hurry in this branch */ > -static void *__load_pointer(const struct sk_buff *skb, int k, unsigned int size) > +/* > + * No hurry in this branch > + * > + * Exported for the bpf jit load helper. > + */
Seems good to me, maybe add a strong warning in the comment to say that function prototype can NOT change without major surgery in ASM files, since assembler wont catch the prototype change for us.
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
| |