lkml.org 
[lkml]   [2012]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets
    From
    From: Jan Seiffert <kaffeemonster@googlemail.com>
    Date: Fri, 30 Mar 2012 17:35:01 +0200

    > Now the helper function from filter.c for negative offsets is exported,
    > it can be used it in the jit to handle negative offsets.
    >
    > First modify the asm load helper functions to handle:
    > - know positive offsets
    > - know negative offsets
    > - any offset
    >
    > then the compiler can be modified to explicitly use these helper
    > when appropriate.
    >
    > This fixes the case of a negative X register and allows to lift
    > the restriction that bpf programs with negative offsets can't
    > be jited.
    >
    > Signed-off-by: Jan Seiffert <kaffeemonster@googlemail.com>
    >
    > I have only compile tested this, -ENOHARDWARE.
    > Can someone with more powerpc kung-fu review and maybe test this?
    > Esp. powerpc asm is not my strong point. I think i botched the
    > stack frame in the call setup. Help?

    I'm not applying this until a powerpc person tests it.

    Also, we have an ARM JIT in the tree which probably needs to
    be fixed similarly.


    \
     
     \ /
      Last update: 2012-04-04 00:07    [W:4.107 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site