Messages in this thread | | | Date | Wed, 05 Dec 2012 08:46:10 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source |
| |
At Tue, 04 Dec 2012 18:17:28 +0000, David Howells wrote: > > Michal Marek <mmarek@suse.cz> wrote: > > > Using the asm .incbin statement in C sources breaks any gcc wrapper which > > assumes that preprocessed C source is self-contained. Use a separate .S > > file to include the siging key and certificate. > > I was trying to avoid that as .S files generally don't crop up in generic > code and the format of the assembly varies with the arch. However, you don't > seem to have anything that should cause a problem
Well, we hit actually the issue... Please check the revised patch again.
thanks,
Takashi
> - so: > > Acked-by: David Howells <dhowells@redhat.com> >
| |