Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source | Date | Tue, 04 Dec 2012 18:17:28 +0000 |
| |
Michal Marek <mmarek@suse.cz> wrote:
> Using the asm .incbin statement in C sources breaks any gcc wrapper which > assumes that preprocessed C source is self-contained. Use a separate .S > file to include the siging key and certificate.
I was trying to avoid that as .S files generally don't crop up in generic code and the format of the assembly varies with the arch. However, you don't seem to have anything that should cause a problem - so:
Acked-by: David Howells <dhowells@redhat.com>
| |