lkml.org 
[lkml]   [2012]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source
Date
Michal Marek <mmarek@suse.cz> wrote:

> Using the asm .incbin statement in C sources breaks any gcc wrapper which
> assumes that preprocessed C source is self-contained. Use a separate .S
> file to include the siging key and certificate.

I was trying to avoid that as .S files generally don't crop up in generic
code and the format of the assembly varies with the arch. However, you don't
seem to have anything that should cause a problem - so:

Acked-by: David Howells <dhowells@redhat.com>


\
 
 \ /
  Last update: 2012-12-04 19:41    [W:2.227 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site