Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source | Date | Wed, 05 Dec 2012 12:35:42 +0000 |
| |
Takashi Iwai <tiwai@suse.de> wrote:
> From: Takashi Iwai <tiwai@suse.de> > Subject: [PATCH v2] MODSIGN: Avoid using .incbin in C source > > Using the asm .incbin statement in C sources breaks any gcc wrapper which > assumes that preprocessed C source is self-contained. Use a separate .S > file to include the siging key and certificate. > > Tested-by: Michal Marek <mmarek@suse.cz> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: David Howells <dhowells@redhat.com>
> +#define GLOBAL(name) \ > + .globl ASM_SYMBOL(name); \ > + ASM_SYMBOL(name):
This should perhaps be moved into a global header.
| |