lkml.org 
[lkml]   [2012]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source
Date
Takashi Iwai <tiwai@suse.de> wrote:

> From: Takashi Iwai <tiwai@suse.de>
> Subject: [PATCH v2] MODSIGN: Avoid using .incbin in C source
>
> Using the asm .incbin statement in C sources breaks any gcc wrapper which
> assumes that preprocessed C source is self-contained. Use a separate .S
> file to include the siging key and certificate.
>
> Tested-by: Michal Marek <mmarek@suse.cz>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Acked-by: David Howells <dhowells@redhat.com>

> +#define GLOBAL(name) \
> + .globl ASM_SYMBOL(name); \
> + ASM_SYMBOL(name):

This should perhaps be moved into a global header.


\
 
 \ /
  Last update: 2012-12-05 14:22    [W:0.090 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site