Messages in this thread | | | Date | Wed, 26 Dec 2012 12:47:35 +0900 | From | Kamezawa Hiroyuki <> | Subject | Re: [PATCH v5 07/14] memory-hotplug: move pgdat_resize_lock into sparse_remove_one_section() |
| |
(2012/12/24 21:09), Tang Chen wrote: > In __remove_section(), we locked pgdat_resize_lock when calling > sparse_remove_one_section(). This lock will disable irq. But we don't need > to lock the whole function. If we do some work to free pagetables in > free_section_usemap(), we need to call flush_tlb_all(), which need > irq enabled. Otherwise the WARN_ON_ONCE() in smp_call_function_many() > will be triggered. > > Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
If this is a bug fix, call-trace in your log and BUGFIX or -fix- in patch title will be appreciated, I think.
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
| |