Messages in this thread | | | Date | Wed, 26 Dec 2012 11:11:01 +0800 | From | Tang Chen <> | Subject | Re: [PATCH v5 08/14] memory-hotplug: Common APIs to support page tables hot-remove |
| |
On 12/26/2012 10:49 AM, Tang Chen wrote: > On 12/25/2012 04:17 PM, Jianguo Wu wrote: >>> + >>> +static void __meminit free_pagetable(struct page *page, int order) >>> +{ >>> + struct zone *zone; >>> + bool bootmem = false; >>> + unsigned long magic; >>> + >>> + /* bootmem page has reserved flag */ >>> + if (PageReserved(page)) { >>> + __ClearPageReserved(page); >>> + bootmem = true; >>> + >>> + magic = (unsigned long)page->lru.next; >>> + if (magic == SECTION_INFO || magic == MIX_SECTION_INFO)
And also, I think we don't need to check MIX_SECTION_INFO since it is for the pageblock_flags, not the memmap in the section.
Thanks. :)
>>> + put_page_bootmem(page); >> >> Hi Tang, >> >> For removing memmap of sparse-vmemmap, in cpu_has_pse case, if magic >> == SECTION_INFO, >> the order will be get_order(PMD_SIZE), so we need a loop here to put >> all the 512 pages. >> > Hi Wu, > > Thanks for reminding me that. I truely missed it. > > And since in register_page_bootmem_info_section(), a whole memory > section will be set as SECTION_INFO, I think we don't need to check > the page magic one by one, just the first one is enough. :) > > I will fix it, thanks. :) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |