Messages in this thread | | | Date | Fri, 28 Dec 2012 09:28:48 +0900 | From | Kamezawa Hiroyuki <> | Subject | Re: [PATCH v5 14/14] memory-hotplug: free node_data when a node is offlined |
| |
(2012/12/27 21:16), Wen Congyang wrote: > At 12/26/2012 11:55 AM, Kamezawa Hiroyuki Wrote: >> (2012/12/24 21:09), Tang Chen wrote: >>> From: Wen Congyang <wency@cn.fujitsu.com> >>> >>> We call hotadd_new_pgdat() to allocate memory to store node_data. So we >>> should free it when removing a node. >>> >>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> >> >> I'm sorry but is it safe to remove pgdat ? All zone cache and zonelists are >> properly cleared/rebuilded in synchronous way ? and No threads are visinting >> zone in vmscan.c ? > > We have rebuilt zonelists when a zone has no memory after offlining some pages. >
How do you guarantee that the address of pgdat/zone is not on stack of any kernel threads or other kernel objects without reference counting or other syncing method ?
Thanks, -Kame
| |