Messages in this thread | | | Date | Sat, 17 Nov 2012 23:50:36 +0100 | Subject | Re: [RFC PATCH 04/06] input/rmi4: Config files and makefiles | From | Linus Walleij <> |
| |
On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny <cheiny@synaptics.com> wrote:
> Infrastructure files for configuration and building. > > > Signed-off-by: Christopher Heiny <cheiny@synaptics.com> >
Cut blank line.
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Linus Walleij <linus.walleij@stericsson.com> > Cc: Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com> > Cc: Joeri de Gram <j.de.gram@gmail.com>
(...) > +++ b/drivers/input/rmi4/Makefile > @@ -0,0 +1,22 @@ > +obj-$(CONFIG_RMI4_BUS) += rmi_bus.o > +obj-$(CONFIG_RMI4_I2C) += rmi_i2c.o > +obj-$(CONFIG_RMI4_GENERIC) += rmi_driver.o rmi_f01.o > +obj-$(CONFIG_RMI4_F11) += rmi_f11.o > + > +ccflags-$(CONFIG_RMI4_DEBUG) += -DDEBUG > +
From here:
> +ifeq ($(KERNELRELEASE),) > + > +# KERNELDIR ?= /home/<AndroidKernelDirectory> > +PWD := $(shell pwd) > + > +.PHONY: build clean > + > +build: > + $(MAKE) -C $(KERNELDIR) M=$(PWD) modules > + > +clean: > + rm -rf *.o *~ core .depend .*.cmd *.ko *.mod.c > + > +endif
This stuff looks weird. Like some local build rule to just rebuild this part, and the commented-out Android thing is really just cruft. Just delete all this, keep it in your private delta if you need it.
Yours, Linus Walleij
| |