lkml.org 
[lkml]   [2012]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 02/06] input/rmi4: Core files
On Fri, Nov 16, 2012 at 07:58:50PM -0800, Christopher Heiny wrote:
> +static void release_rmidev_device(struct device *dev)
> +{
> + device_unregister(dev);
> +}

You just leaked memory here, right?

Also, you already unregistered the device, otherwise this function would
have never been called, so you just ended up in a loop?

Have you ever tried removing a device? Are you sure it's working
properly?

> +EXPORT_SYMBOL(rmi_register_phys_device);

Just curious, but why not EXPORT_SYMBOL_GPL() on all of these new
symbols you are creating?

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-11-17 23:21    [W:0.110 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site