Messages in this thread | | | Date | Mon, 19 Nov 2012 20:56:12 -0800 | From | Christopher Heiny <> | Subject | Re: [RFC PATCH 02/06] input/rmi4: Core files |
| |
On 11/17/2012 01:54 PM, Greg Kroah-Hartman wrote: > On Fri, Nov 16, 2012 at 07:58:50PM -0800, Christopher Heiny wrote: >> +static void release_rmidev_device(struct device *dev) >> +{ >> + device_unregister(dev); >> +} > > You just leaked memory here, right? > > Also, you already unregistered the device, otherwise this function would > have never been called, so you just ended up in a loop?
Roger. We'll fix that.
> Have you ever tried removing a device? Are you sure it's working > properly?
Hmmmm. If it leads to the loop you mention above, then the test I'm using must not be doing what I thought it was. I'll fix that, too.
>> +EXPORT_SYMBOL(rmi_register_phys_device); > > Just curious, but why not EXPORT_SYMBOL_GPL() on all of these new > symbols you are creating?
We'll change that.
Thanks very much! Chris
| |