Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 09 Nov 2011 13:27:40 -0500 | From | Mark Lord <> | Subject | Re: [PATCH v2] drivers/net/usb/asix: resync from vendor's copy |
| |
On 11-11-09 12:47 PM, Ben Hutchings wrote: > On Wed, 2011-11-09 at 12:31 -0500, Mark Lord wrote: > [...] >> +static int ax88172_link_reset(struct usbnet *dev) >> +{ >> + u16 lpa; >> + u16 adv; >> + u16 res; >> + u8 mode; >> + >> + mode = AX_MEDIUM_TX_ABORT_ALLOW | AX_MEDIUM_FLOW_CONTROL_EN; >> + lpa = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_LPA); >> + adv = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_ADVERTISE); >> + res = mii_nway_result(lpa|adv); > [...] > > The argument to mii_nway_result() must be lpa & adv (the intersection of > supported modes, not the union!).
Excellent. Fixed.
| ![\](/images/icornerr.gif) |