lkml.org 
[lkml]   [2011]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] drivers/net/usb/asix: resync from vendor's copy
From
Date
On Wed, 2011-11-09 at 12:31 -0500, Mark Lord wrote:
[...]
> +static int ax88172_link_reset(struct usbnet *dev)
> +{
> + u16 lpa;
> + u16 adv;
> + u16 res;
> + u8 mode;
> +
> + mode = AX_MEDIUM_TX_ABORT_ALLOW | AX_MEDIUM_FLOW_CONTROL_EN;
> + lpa = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_LPA);
> + adv = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_ADVERTISE);
> + res = mii_nway_result(lpa|adv);
[...]

The argument to mii_nway_result() must be lpa & adv (the intersection of
supported modes, not the union!).

Ben

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.



\
 
 \ /
  Last update: 2011-11-09 18:49    [W:0.809 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site