Messages in this thread | | | Date | Wed, 09 Nov 2011 12:41:42 -0500 | From | Mark Lord <> | Subject | Re: [PATCH v2] drivers/net/usb/asix: resync from vendor's copy |
| |
On 11-11-09 12:31 PM, Mark Lord wrote: > Second pass (for review) at updating the in-kernel asix usb/network driver > from the v4.1.0 vendor GPL version of the driver, obtained from here: > > http://www.asix.com.tw/download.php?sub=searchresult&PItemID=84&download=driver > > The original vendor copy used a local "axusbnet" middleware (rather than "usbnet"). > I've converted it back to using "usbnet", made a ton of cosmetic changes > to get it to pass checkpatch.pl, and removed a small amount of code duplication. > > The tx/rx checksum code has been updated per Ben's comments, > and the duplicated MII_* definitions have been removed. > I've changed the version string to be "4.1.0-kernel", > to reflect the vendor's code version while also distinguishing > this port from the original vendor code. > > It can use more work going forward, but it is important to get it upstream > sooner than later -- the current in-kernel driver fails with many devices, > both old and new. This updated version works with everything I have available > to test with, and also handles suspend / resume (unlike the in-kernel one). > > Signed-off-by: Mark Lord <mlord@pobox.com> > --- > Note that the vendor now has a v4.2.0 version available, > but for now I'm concentrating on the original v4.1.0 code. > > After review/discussion of this patch, I will update for Linux-3.2-rc > and resubmit for inclusion in the eventual linux-3.3 kernel. > > Patch included below, and also attached to bypass mailer mangling.
.. > +#define AX_RX_CHECKSUM (1 << 0) > +#define AX_TX_CHECKSUM (1 << 1) ..
Please consider those two lines (from asix.h) to be "nuked" from the next version.
| |