lkml.org 
[lkml]   [2011]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems
From
Date

On Oct 13, 2011, at 10:37 AM, David Laight wrote:

>
>> Kumar Gala wrote:
>>>>>>> + phys_addr_t addr;
>>>>>
>>>>> Please add a comment here saying:
>>>>>
>>>>> 1) That 'addr' can be a virtual or physical address
>>> The code and everything else makes that clear
>>
>> I'm sorry, but I have to strongly disagree here. It is *NOT*
>> clear that a variable of type 'phys_addr_t' can hold something
>> that is not a physical address.
>
> Since there is a discriminating field, could a union be used?
> At a guess the type of the address is constrained between
> produces and consumer??

Uugh.

I'll add a comment to uio_mem.

- k


\
 
 \ /
  Last update: 2011-10-13 17:53    [W:0.025 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site