Messages in this thread | | | Date | Thu, 13 Oct 2011 10:34:17 -0500 | From | Timur Tabi <> | Subject | Re: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems |
| |
Kumar Gala wrote: >>> >> + phys_addr_t addr; >> > >> > Please add a comment here saying: >> > >> > 1) That 'addr' can be a virtual or physical address > The code and everything else makes that clear
I'm sorry, but I have to strongly disagree here. It is *NOT* clear that a variable of type 'phys_addr_t' can hold something that is not a physical address.
-- Timur Tabi Linux kernel developer at Freescale
| |