Messages in this thread | | | Subject | RE: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems | Date | Thu, 13 Oct 2011 16:37:20 +0100 | From | "David Laight" <> |
| |
> Kumar Gala wrote: > >>> >> + phys_addr_t addr; > >> > > >> > Please add a comment here saying: > >> > > >> > 1) That 'addr' can be a virtual or physical address > > The code and everything else makes that clear > > I'm sorry, but I have to strongly disagree here. It is *NOT* > clear that a variable of type 'phys_addr_t' can hold something > that is not a physical address.
Since there is a discriminating field, could a union be used? At a guess the type of the address is constrained between produces and consumer??
David
| |