Messages in this thread Patch in this message | | | Date | Tue, 22 Sep 2009 13:51:54 +0800 | From | Li Zefan <> | Subject | [PATCH 1/4] tracing: fix off-by-one in trace_get_user() |
| |
Leave the last slot for the tailing '\0'.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> ---
I spent some time reviewing the trace parser patchset, and found a few small bugs in it, and here are the fixes.
--- kernel/trace/trace.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index a35925d..ae17453 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -415,7 +415,7 @@ int trace_get_user(struct trace_parser *parser, const char __user *ubuf, /* read the non-space input */ while (cnt && !isspace(ch)) { - if (parser->idx < parser->size) + if (parser->idx < parser->size - 1) parser->buffer[parser->idx++] = ch; else { ret = -EINVAL; -- 1.6.3
| |