Messages in this thread Patch in this message | | | Date | Tue, 22 Sep 2009 08:39:36 GMT | From | tip-bot for Li Zefan <> | Subject | [tip:tracing/urgent] tracing: Fix off-by-one in trace_get_user() |
| |
Commit-ID: 3c235a337e205da0f614e456be72881483dcde6e Gitweb: http://git.kernel.org/tip/3c235a337e205da0f614e456be72881483dcde6e Author: Li Zefan <lizf@cn.fujitsu.com> AuthorDate: Tue, 22 Sep 2009 13:51:54 +0800 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Tue, 22 Sep 2009 10:28:53 +0200
tracing: Fix off-by-one in trace_get_user()
Leave the last slot for the tailing '\0'.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Steven Rostedt <rostedt@goodmis.org> LKML-Reference: <4AB865FA.5080801@cn.fujitsu.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- kernel/trace/trace.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index a35925d..ae17453 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -415,7 +415,7 @@ int trace_get_user(struct trace_parser *parser, const char __user *ubuf, /* read the non-space input */ while (cnt && !isspace(ch)) { - if (parser->idx < parser->size) + if (parser->idx < parser->size - 1) parser->buffer[parser->idx++] = ch; else { ret = -EINVAL;
| |