lkml.org 
[lkml]   [2008]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] integrity: special fs magic
On Fri, Aug 08, 2008 at 12:15:19PM -0700, Greg KH wrote:
> On Fri, Aug 08, 2008 at 12:04:48PM -0700, Greg KH wrote:
> > On Fri, Aug 08, 2008 at 02:55:42PM -0400, Mimi Zohar wrote:
> > > - Move special fs magic number definitions to magic.h
> > > - Add magic.h include
> > >
> > > Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
> >
> > Why? What is this patch for? Are you going to do something with these
> > magic values later?
>
> Ok, I now see the follow-up patch that does something with them.
>
> You should say so in this patch.
>
> And is it really ok to be doing things from userspace based on a
> filesystem "magic" key? Those are numbers we have never exported to
> userspace before, what happens if they are changed?

These constants re exported to userspace in struct statfs .type and
better don't change. Providing the symbolic names for them sounds
like a good idea to me. What userspace does with that or not is
their business, and if it's utterly stupid it'll be their fault if
it doesn't work as expected..


\
 
 \ /
  Last update: 2008-08-09 20:51    [W:0.074 / U:0.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site