lkml.org 
[lkml]   [2008]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] integrity: special fs magic
On Fri, Aug 08, 2008 at 12:04:48PM -0700, Greg KH wrote:
> On Fri, Aug 08, 2008 at 02:55:42PM -0400, Mimi Zohar wrote:
> > - Move special fs magic number definitions to magic.h
> > - Add magic.h include
> >
> > Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
>
> Why? What is this patch for? Are you going to do something with these
> magic values later?

Ok, I now see the follow-up patch that does something with them.

You should say so in this patch.

And is it really ok to be doing things from userspace based on a
filesystem "magic" key? Those are numbers we have never exported to
userspace before, what happens if they are changed?

thanks,

greg k-h


\
 
 \ /
  Last update: 2008-08-08 21:19    [W:0.145 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site