lkml.org 
[lkml]   [2008]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] integrity: special fs magic
On Fri, Aug 08, 2008 at 03:50:02PM -0400, Mimi Zohar wrote:
> Greg KH <greg@kroah.com> wrote on 08/08/2008 03:15:19 PM:
>
> > On Fri, Aug 08, 2008 at 12:04:48PM -0700, Greg KH wrote:
> > > On Fri, Aug 08, 2008 at 02:55:42PM -0400, Mimi Zohar wrote:
> > > > - Move special fs magic number definitions to magic.h
> > > > - Add magic.h include
> > > >
> > > > Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
> > >
> > > Why? What is this patch for? Are you going to do something with
> these
> > > magic values later?
> >
> > Ok, I now see the follow-up patch that does something with them.
> >
> > You should say so in this patch.
> >
> > And is it really ok to be doing things from userspace based on a
> > filesystem "magic" key? Those are numbers we have never exported to
> > userspace before, what happens if they are changed?
> >
> > thanks,
> >
> > greg k-h
>
> Userspace only loads the measurement policy (via securityfs), and if
> a magic number changes, and the policy is not updated to match, then
> we would end up measuring some filesystems we didn't need to. Before
> the magic numbers were hard coded in IMA, now at least, it's extensible.

Why not just use a name then instead? That way if the number changes
within the kernel, then it will always be right.

thanks,

greg k-h


\
 
 \ /
  Last update: 2008-08-09 01:19    [W:0.040 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site