lkml.org 
[lkml]   [2008]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol
>	ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);
> if (!ptr)
> panic("Can not alloc dyn_alloc\n");

Why duplicate the panic()? Just call __alloc_bootmem().

> #ifdef CONFIF_GENERIC_HARDIRQS

That doesn't appear to have been very well tested?

The code has a few coding-style glitches which checkpatch can detect.


\
 
 \ /
  Last update: 2008-08-30 00:57    [W:0.185 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site