lkml.org 
[lkml]   [2008]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol
On Fri, Aug 29, 2008 at 3:53 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>> ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);
>> if (!ptr)
>> panic("Can not alloc dyn_alloc\n");

like to give exact error message.

>
> Why duplicate the panic()? Just call __alloc_bootmem().
>
>> #ifdef CONFIF_GENERIC_HARDIRQS
>
> That doesn't appear to have been very well tested?

ah!
it should break sparc, m68k, and s390...

>
> The code has a few coding-style glitches which checkpatch can detect.
>

should only have 80 char length warning...

YH


\
 
 \ /
  Last update: 2008-08-30 01:37    [W:0.051 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site