Messages in this thread | | | Date | Fri, 29 Aug 2008 15:20:53 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol |
| |
On Fri, 29 Aug 2008 15:07:49 -0700 Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> + printk(KERN_DEBUG "per_cpu_dyn_array %pF ==> [%#lx - %#lx]\n", > + da->name, phys, phys + size);
This:
struct dyn_array { void **name;
is a bit confusing. One normally expects a variable called "name" to point at a character string.
What _does_ this thing point at? There are no code comments which I can find, it's unobvious from the source code, the type is the information-free void** and the identifier is misleading.
I find that documenting the data structures is the best way of making code understandable (and hence maintainable).
| |