lkml.org 
[lkml]   [2008]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch 12/17] Use WARN() in block/
From: Arjan van de Ven <arjan@linux.intel.com>
Subject: Use WARN instead of printk+WARN_ON in block

Use WARN() instead of a printk+WARN_ON() pair; this way the message
becomes part of the warning section for better reporting/collection.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>---
block/as-iosched.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux.trees.git/block/as-iosched.c
===================================================================
--- linux.trees.git.orig/block/as-iosched.c
+++ linux.trees.git/block/as-iosched.c
@@ -837,8 +837,7 @@ static void as_completed_request(struct
WARN_ON(!list_empty(&rq->queuelist));

if (RQ_STATE(rq) != AS_RQ_REMOVED) {
- printk("rq->state %d\n", RQ_STATE(rq));
- WARN_ON(1);
+ WARN(1, "rq->state %d\n", RQ_STATE(rq));
goto out;
}


\
 
 \ /
  Last update: 2008-07-08 19:05    [W:0.202 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site