Messages in this thread Patch in this message | | | Date | Tue, 8 Jul 2008 09:47:26 -0700 | From | Arjan van de Ven <> | Subject | [patch 7/17] use WARN() in kernel/lockdep.c |
| |
From: Arjan van de Ven <arjan@linux.intel.com> Subject: Use WARN instead of printk+WARN_ON in kernel/lockdep.c
Use WARN() instead of a printk+WARN_ON() pair; this way the message becomes part of the warning section for better reporting/collection.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> --- kernel/lockdep.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Index: linux.trees.git/kernel/lockdep.c =================================================================== --- linux.trees.git.orig/kernel/lockdep.c +++ linux.trees.git/kernel/lockdep.c @@ -1643,11 +1643,10 @@ static void check_chain_key(struct task_ hlock = curr->held_locks + i; if (chain_key != hlock->prev_chain_key) { debug_locks_off(); - printk("hm#1, depth: %u [%u], %016Lx != %016Lx\n", + WARN(1, "hm#1, depth: %u [%u], %016Lx != %016Lx\n", curr->lockdep_depth, i, (unsigned long long)chain_key, (unsigned long long)hlock->prev_chain_key); - WARN_ON(1); return; } id = hlock->class - lock_classes; @@ -1662,11 +1661,10 @@ static void check_chain_key(struct task_ } if (chain_key != curr->curr_chain_key) { debug_locks_off(); - printk("hm#2, depth: %u [%u], %016Lx != %016Lx\n", + WARN(1, "hm#2, depth: %u [%u], %016Lx != %016Lx\n", curr->lockdep_depth, i, (unsigned long long)chain_key, (unsigned long long)curr->curr_chain_key); - WARN_ON(1); } #endif }
| |