Messages in this thread | | | Date | Thu, 24 Apr 2008 08:51:52 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH -mm crypto] AES: x86_64 asm implementation optimization |
| |
On Thu, Apr 24, 2008 at 12:28:43AM +0200, Sebastian Siewior wrote: > >> __crt_ctx in crypto_tfm is aligned in CRYPTO_MINALIGN. So I think adding > >> a pad is sufficient for x86_64 implementation. > > > >It should be sufficient but it would be better to use an align > Doesn't this imply that kmalloc() returns memory that is always pointer > aligned what isn't the case AFAIK?
Parse error :)
kmalloc returns memory that should always be aligned to CRYPTO_MINALIGN and in particular it's always pointer aligned.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |