Messages in this thread | | | Date | Thu, 17 Apr 2008 11:34:02 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH -mm crypto] AES: x86_64 asm implementation optimization |
| |
On Thu, Apr 17, 2008 at 09:52:03AM +0800, Huang, Ying wrote: > > As far as I know, the CRYPTO_MINALIGN is defined in > include/linux/crypto.h as __alignof__(unsigned long long), and the > __crt_ctx in crypto_tfm is aligned in CRYPTO_MINALIGN. So I think adding > a pad is sufficient for x86_64 implementation.
It should be sufficient but it would be better to use an align attribute to better document the intention.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |