lkml.org 
[lkml]   [2008]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm crypto] AES: x86_64 asm implementation optimization
    On Thu, Apr 17, 2008 at 09:52:03AM +0800, Huang, Ying wrote:
    >
    > As far as I know, the CRYPTO_MINALIGN is defined in
    > include/linux/crypto.h as __alignof__(unsigned long long), and the
    > __crt_ctx in crypto_tfm is aligned in CRYPTO_MINALIGN. So I think adding
    > a pad is sufficient for x86_64 implementation.

    It should be sufficient but it would be better to use an align
    attribute to better document the intention.

    Thanks,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2008-04-17 05:37    [W:2.764 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site