Messages in this thread | | | Subject | Re: [PATCH -mm crypto] AES: x86_64 asm implementation optimization | From | "Huang, Ying" <> | Date | Thu, 17 Apr 2008 12:53:13 +0800 |
| |
On Thu, 2008-04-17 at 11:34 +0800, Herbert Xu wrote: > On Thu, Apr 17, 2008 at 09:52:03AM +0800, Huang, Ying wrote: > > > > As far as I know, the CRYPTO_MINALIGN is defined in > > include/linux/crypto.h as __alignof__(unsigned long long), and the > > __crt_ctx in crypto_tfm is aligned in CRYPTO_MINALIGN. So I think adding > > a pad is sufficient for x86_64 implementation. > > It should be sufficient but it would be better to use an align > attribute to better document the intention.
OK. I will use the align attribute.
Best Regards, Huang Ying
| |