lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] xfs: #define out unused parameters of xfs bmap add free and xfs_btree_read_bufl
Date
On Tuesday 22 April 2008 19:26, Eric Sandeen wrote:
> It would be a huge undertaking.
>
> Just building xfs w/ the warning in place exposes tons of unused
> parameter warnings from outside xfs as well.

I was grepping them away.

> But, if it was deemed important enough, you could go annotate them as
> unused, I suppose, and hack away at it... Does marking as unused just
> shut up the warning or does it let gcc do further optimizations?

It just shuts up the warning. It is still useful - suppresses
false positives.

I didn't check whether gcc is clever enough to reuse stack space
occupied by unused parameter(s) as a free space for automatic
variables. In theory it is allowed to do that and reduce stack usage
that way.
--
vda


\
 
 \ /
  Last update: 2008-04-22 22:49    [W:0.190 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site