Messages in this thread | | | From | Denys Vlasenko <> | Subject | Re: [PATCH] xfs: #define out unused parameters of?xfs_bmap_add_free and xfs_btree_read_bufl | Date | Tue, 22 Apr 2008 21:32:38 +0200 |
| |
On Tuesday 22 April 2008 20:28, Adrian Bunk wrote: > > Eh... I meant "no warnings about unused parameters" for fs/xfs/* only, > > not for the entire kernel. I filter out other warnings. > > > > I want to do it not as an excercise in perfectionism, > > but as means of making sure we do not waste stack > > passing useless parameters, which is important for xfs. > > That's not really maintainable,
Why? Adding -Wunused -Wunused-parameter in fs/xfs/Makefile:
EXTRA_CFLAGS += -I$(src) -I$(src)/linux-2.6 -funsigned-char #EXTRA_CFLAGS += -Wunused -Wunused-parameter
and making a test build with it uncommented once in a while will reveal a bit of fallout, which is then fixed. busybox source is thrice as big as xfs source and from the experience I'd say it's not difficult to keep it in shape.
> and the stack gains are too small for > bringing us significantely nearer to a solution.
I promise to take a look at the critical (wrt stack use) path next. -- vda
| |