Messages in this thread | | | From | Denys Vlasenko <> | Subject | Re: [PATCH] xfs: #define out unused parameters of xfs bmap add free and xfs_btree_read_bufl | Date | Tue, 22 Apr 2008 19:50:54 +0200 |
| |
On Tuesday 22 April 2008 19:26, Eric Sandeen wrote: > >> I want to eventually reach the state with no warnings > >> about unused parameters. > > > > The standard kernel pattern in using empty static inline functions (that > > allow type checking). > > > > And I'm not sure whether the number of functions you'd have to change > > for reaching your goal has four, five or six digits. > > It would be a huge undertaking. > > Just building xfs w/ the warning in place exposes tons of unused > parameter warnings from outside xfs as well.
Eh... I meant "no warnings about unused parameters" for fs/xfs/* only, not for the entire kernel. I filter out other warnings.
I want to do it not as an excercise in perfectionism, but as means of making sure we do not waste stack passing useless parameters, which is important for xfs. -- vda
| |