lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC)
Hello.

Takashi Iwai wrote:
> It's no big problem but I just find the phrase "you have to
> disable..." too strict. It's just a sound-quality problem as you
> mentioned in the above.
> BTW, I noticed that the message includes a few line breaks. You need
> a proper KERN_ prefix for each line in such a case. A fix patch would
> be appreciated.
Like the attached one?
# HG changeset patch
# User Stas Sergeev <stsp@users.sourceforge.net>
# Date 1208888978 -14400
# Node ID 00c36aa3903d861198e8f57c46e75194f3e172d6
# Parent f8fbce7ba45922a73a9679d68c4a4b07ebef42de
pcsp: fix wording in DEBUG_PAGEALLOC warning.

Signed-off-by: Stas Sergeev <stsp@aknet.ru>

diff -r f8fbce7ba459 -r 00c36aa3903d drivers/pcsp/pcsp.c
--- a/drivers/pcsp/pcsp.c Tue Apr 22 18:39:49 2008 +0200
+++ b/drivers/pcsp/pcsp.c Tue Apr 22 22:29:38 2008 +0400
@@ -147,12 +147,8 @@ static int __devinit alsa_card_pcsp_init

#ifdef CONFIG_DEBUG_PAGEALLOC
/* Well, CONFIG_DEBUG_PAGEALLOC makes the sound horrible. Lets alert */
- printk(KERN_WARNING
- "PCSP: Warning, CONFIG_DEBUG_PAGEALLOC is enabled!\n"
- "You have to disable it if you want to use the PC-Speaker "
- "driver.\n"
- "Unless it is disabled, enjoy the horrible, distorted "
- "and crackling noise.\n");
+ printk(KERN_WARNING "PCSP: CONFIG_DEBUG_PAGEALLOC is enabled, "
+ KERN_WARNING "which may make the sound noisy.\n");
#endif

return 0;
\
 
 \ /
  Last update: 2008-04-22 20:35    [W:0.127 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site