lkml.org 
[lkml]   [2008]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC)
    At Wed, 23 Apr 2008 10:49:00 +0200,
    I wrote:
    >
    > At Tue, 22 Apr 2008 22:31:01 +0400,
    > Stas Sergeev wrote:
    > >
    > > # HG changeset patch
    > > # User Stas Sergeev <stsp@users.sourceforge.net>
    > > # Date 1208888978 -14400
    > > # Node ID 00c36aa3903d861198e8f57c46e75194f3e172d6
    > > # Parent f8fbce7ba45922a73a9679d68c4a4b07ebef42de
    > > pcsp: fix wording in DEBUG_PAGEALLOC warning.
    > >
    > > Signed-off-by: Stas Sergeev <stsp@aknet.ru>
    > >
    > > diff -r f8fbce7ba459 -r 00c36aa3903d drivers/pcsp/pcsp.c
    > > --- a/drivers/pcsp/pcsp.c Tue Apr 22 18:39:49 2008 +0200
    > > +++ b/drivers/pcsp/pcsp.c Tue Apr 22 22:29:38 2008 +0400
    > > @@ -147,12 +147,8 @@ static int __devinit alsa_card_pcsp_init
    > >
    > > #ifdef CONFIG_DEBUG_PAGEALLOC
    > > /* Well, CONFIG_DEBUG_PAGEALLOC makes the sound horrible. Lets alert */
    > > - printk(KERN_WARNING
    > > - "PCSP: Warning, CONFIG_DEBUG_PAGEALLOC is enabled!\n"
    > > - "You have to disable it if you want to use the PC-Speaker "
    > > - "driver.\n"
    > > - "Unless it is disabled, enjoy the horrible, distorted "
    > > - "and crackling noise.\n");
    > > + printk(KERN_WARNING "PCSP: CONFIG_DEBUG_PAGEALLOC is enabled, "
    > > + KERN_WARNING "which may make the sound noisy.\n");
    >
    > Missing \n in the first line?

    Fixed on ALSA tree now, too.


    Takashi


    \
     
     \ /
      Last update: 2008-04-23 16:21    [W:4.047 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site