lkml.org 
[lkml]   [2008]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled
Hi Mark,

On Mon, Apr 14, 2008 at 06:39:33PM +0100, Mark Brown wrote:
> static irqreturn_t wm97xx_pen_interrupt(int irq, void *dev_id)
> {
> struct wm97xx *wm = dev_id;
>
> - wm->mach_ops->irq_enable(wm, 0);
> - queue_work(wm->ts_workq, &wm->pen_event_work);
> + if (!work_pending(&wm->pen_event_work)) {
> + wm->mach_ops->irq_enable(wm, 0);
> + queue_work(wm->ts_workq, &wm->pen_event_work);
> + }

Given the fact that work will not be queued if it is pending anyway
why is this change needed?

--
Dmitry


\
 
 \ /
  Last update: 2008-04-14 20:13    [W:2.075 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site