lkml.org 
[lkml]   [2008]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled
On Mon, Apr 14, 2008 at 02:10:02PM -0400, Dmitry Torokhov wrote:
> On Mon, Apr 14, 2008 at 06:39:33PM +0100, Mark Brown wrote:

> > + if (!work_pending(&wm->pen_event_work)) {
> > + wm->mach_ops->irq_enable(wm, 0);
> > + queue_work(wm->ts_workq, &wm->pen_event_work);
> > + }

> Given the fact that work will not be queued if it is pending anyway
> why is this change needed?

As well as not queuing the work it ensures that the calls to
irq_enable() are balanced which helps with implementing that operation.


\
 
 \ /
  Last update: 2008-04-15 10:51    [W:0.116 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site