Messages in this thread | | | Date | Tue, 15 Apr 2008 09:48:19 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled |
| |
On Mon, Apr 14, 2008 at 02:10:02PM -0400, Dmitry Torokhov wrote: > On Mon, Apr 14, 2008 at 06:39:33PM +0100, Mark Brown wrote:
> > + if (!work_pending(&wm->pen_event_work)) { > > + wm->mach_ops->irq_enable(wm, 0); > > + queue_work(wm->ts_workq, &wm->pen_event_work); > > + }
> Given the fact that work will not be queued if it is pending anyway > why is this change needed?
As well as not queuing the work it ensures that the calls to irq_enable() are balanced which helps with implementing that operation.
| |