Messages in this thread | | | Date | Wed, 31 Dec 2008 16:34:41 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH 01/15] ACPI: create kernel/acpi/ |
| |
On Wed, Dec 31, 2008 at 03:21:08PM +0100, Andi Kleen wrote: > Sam Ravnborg <sam@ravnborg.org> writes: > > Why is ACPI_CFLAGS exported? > >> +ACPI_CFLAGS := -Os > >> + > >> +ifdef CONFIG_ACPI_DEBUG > >> + ACPI_CFLAGS += -DACPI_DEBUG_OUTPUT > >> +endif > >> + > >> +EXTRA_CFLAGS += $(ACPI_CFLAGS) > > A better way: > > > > ccflags-$(CONFIG_ACPI_DEBUG) := -DACPI_DEBUG_OUTPUT > > Surely s/:=/+=/ ?
Only if ccflags-y is assigned earlier in the same file otherwise it does not matter.
Sam
| |