Messages in this thread | | | Date | Fri, 2 Jan 2009 22:52:08 +0100 | From | Sam Ravnborg <> | Subject | Re: [incremental-PATCH-for-Sam's-Review] ACPI: use ccflags-y instead of EXTRA_CFLAGS |
| |
On Fri, Jan 02, 2009 at 04:44:02PM -0500, Len Brown wrote: > From: Len Brown <len.brown@intel.com> > > Signed-off-by: Len Brown <len.brown@intel.com> > --- > drivers/acpi/Makefile | 11 ++--------- > kernel/acpi/Makefile | 11 ++--------- > kernel/acpi/acpica/Makefile | 12 ++---------- > 3 files changed, 6 insertions(+), 28 deletions(-) > > diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile > index 5f4096d..a4c0582 100644 > --- a/drivers/acpi/Makefile > +++ b/drivers/acpi/Makefile > @@ -2,15 +2,8 @@ > # Makefile for the Linux ACPI Drivers > # > > -export ACPI_CFLAGS > - > -ACPI_CFLAGS := -Os > - > -ifdef CONFIG_ACPI_DEBUG > - ACPI_CFLAGS += -DACPI_DEBUG_OUTPUT > -endif > - > -EXTRA_CFLAGS += $(ACPI_CFLAGS) > +ccflags-y := -Os > +ccflags-$(CONFIG_ACPI_DEBUG) += -DACPI_DEBUG_OUTPUT
The conversion from ACPI_CFLAGS to ccflags-y is fine. And if acpi really require -Os then this part is also OK - I just did not get *why* acpi needs -Os
On the assumption the the -Os requirement is a hard requirement:
Acked-by: Sam Ravnborg <sam@ravnborg.org> [For the full patch - I just quoted the first part]
Sam
| |