lkml.org 
[lkml]   [2008]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/15] ACPI: create kernel/acpi/
> diff --git a/kernel/acpi/Makefile b/kernel/acpi/Makefile
> new file mode 100644
> index 0000000..92a1f94
> --- /dev/null
> +++ b/kernel/acpi/Makefile
> @@ -0,0 +1,26 @@
> +#
> +# Makefile for the Linux/ACPI
> +#
> +
> +export ACPI_CFLAGS
> +

Why is ACPI_CFLAGS exported?
> +ACPI_CFLAGS := -Os
> +
> +ifdef CONFIG_ACPI_DEBUG
> + ACPI_CFLAGS += -DACPI_DEBUG_OUTPUT
> +endif
> +
> +EXTRA_CFLAGS += $(ACPI_CFLAGS)
A better way:

ccflags-$(CONFIG_ACPI_DEBUG) := -DACPI_DEBUG_OUTPUT

Note: EXTRA_CFLAGS is deprecated in favour of ccflags-y.

> +export ACPI_CFLAGS
> +
> +ACPI_CFLAGS := -Os
> +
> +ifdef CONFIG_ACPI_DEBUG
> + ACPI_CFLAGS += -DACPI_DEBUG_OUTPUT
> +endif
> +
> +EXTRA_CFLAGS += $(ACPI_CFLAGS)

Same construct - see above.

Sam


\
 
 \ /
  Last update: 2008-12-31 14:39    [W:0.069 / U:1.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site