lkml.org 
[lkml]   [2008]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: mmotm 2008-11-29-01-53 uploaded
On Sat, 29 Nov 2008 01:59:56 -0800
akpm@linux-foundation.org wrote:

> The mm-of-the-moment snapshot 2008-11-29-01-53 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> It contains the following patches against 2.6.28-rc6:
>
Hi, in recent changes of linux-next.patch

==
static void __init param_sysfs_builtin(void)
{
struct kernel_param *kp;
unsigned int name_len;
char modname[MODULE_NAME_LEN];

for (kp = __start___param; kp < __stop___param; kp++) {
char *dot;

if (kp->perm == 0)
continue;

dot = strchr(kp->name, '.');
BUG_ON(!dot); <======================================(*)
name_len = dot - kp->name + 1;
strlcpy(modname, kp->name, name_len);
kernel_add_sysfs_param(modname, kp, name_len);
}

==
Above (*) is added.

I hit BUG_ON() at (*). That was because usbcore was not a module and module param
kp->name was "nousb".... not including any dot.
(If compled as module, the kernel works well.)

I'm sorry if already fixed.

Thanks,
-Kame









\
 
 \ /
  Last update: 2008-12-01 03:13    [W:0.074 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site