lkml.org 
[lkml]   [2008]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: mmotm 2008-11-29-01-53 uploaded
On Mon, 1 Dec 2008 11:10:40 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

> On Sat, 29 Nov 2008 01:59:56 -0800
> akpm@linux-foundation.org wrote:
>
> > The mm-of-the-moment snapshot 2008-11-29-01-53 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
> >
> > It contains the following patches against 2.6.28-rc6:
> >
> Hi, in recent changes of linux-next.patch
>
> ==
> static void __init param_sysfs_builtin(void)
> {
> struct kernel_param *kp;
> unsigned int name_len;
> char modname[MODULE_NAME_LEN];
>
> for (kp = __start___param; kp < __stop___param; kp++) {
> char *dot;
>
> if (kp->perm == 0)
> continue;
>
> dot = strchr(kp->name, '.');
> BUG_ON(!dot); <======================================(*)
> name_len = dot - kp->name + 1;
> strlcpy(modname, kp->name, name_len);
> kernel_add_sysfs_param(modname, kp, name_len);
> }
>
> ==
> Above (*) is added.
>
> I hit BUG_ON() at (*). That was because usbcore was not a module and module param
> kp->name was "nousb".... not including any dot.
> (If compled as module, the kernel works well.)
>

Thanks, that'll be

commit 9b473de87209fa86eb421b23386693b461612f30
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Wed Oct 22 10:00:22 2008 -0500

param: Fix duplicate module prefixes

I assume. Rusty's been on the schnapps again ;)


\
 
 \ /
  Last update: 2008-12-01 04:13    [W:0.032 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site