Messages in this thread | | | From | Mark Nelson <> | Subject | commit "genirq: record trigger type" and powerpc | Date | Thu, 13 Nov 2008 17:30:11 +1100 |
| |
Hi Ingo,
I noticed that after commit 0c5d1eb77a8be917b638344a22afe1398236482b (genirq: record trigger type), several of our powerpc platforms now spew out warnings about "No set_type function for IRQ..." (in particular our Cell blades). This is because in our generic platform code we call set_irq_type() with information from the device tree when we establish the interrupt mappings; but we do this regardless of whether the PIC can actually set a type (it might irrelevant because the type is essentially hardcoded or as in the case for Cell the interrupts are just messages being past around that have no real concept of type, or we could even be dealing with a virtual PIC as on the PS3).
So, would it be possible to turn the:
pr_warning("No set_type function...
into a pr_debug() in kernel/irq/manage.c so when our users upgrade to newer kernels they don't get scared by a whole bunch of new warnings?
Many thanks!
Mark
| |