Messages in this thread | | | Date | Thu, 13 Nov 2008 12:11:36 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] genirq: __irq_set_trigger: change pr_warning to pr_debug |
| |
* Mark Nelson <markn@au1.ibm.com> wrote:
> Commit 0c5d1eb77a8be917b638344a22afe1398236482b (genirq: record > trigger type) caused powerpc platforms that had no set_type() > function in their struct irq_chip to spew out warnings about "No > set_type function for IRQ...". This warning isn't necessarily > justified though because the generic powerpc platform code calls > set_irq_type() (which in turn calls __irq_set_trigger) with > information from the device tree to establish the interrupt > mappings, regardless of whether the PIC can actually set a type. > > A platform's irq_chip might not have a set_type function for a > variety of reasons, for example: the platform may have the type > essentially hard-coded, or as in the case for Cell interrupts are > just messages past around that have no real concept of type, or the > platform could even have a virtual PIC as on the PS3. > > Signed-off-by: Mark Nelson <markn@au1.ibm.com> > --- > Thanks Ingo! Much appreciated > > kernel/irq/manage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
applied to tip/irq/urgent, thanks Mark!
Ingo
| |