lkml.org 
[lkml]   [2008]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Handle space after for_each_* macros gracefully in checkpatch
Handle space after for_each_* macros gracefully in checkpatch.pl

Anyone else seeing the irony of checkpatch.pl recommending to
use for_each_cpu_mask, but then not actually parsing it
correctly.

When you write

for_each_cpu_mask (...) {

it would complain about the space between mask and the open bracket
because it thinks it's a normal function call.

Fix this in a generic way. In theory someone could construct
a normal function that starts with for_each_* and it would
not warn, but I think that would be uncommon. The alternative
of listing all macros was tried first, but turned out to
be unwieldly.

I think I covered most of the common ones available, the
only exceptions are a few oddballs with leading prefix
like pnp_for_each* or zorro_for_each.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

Index: linux-2.6.27-misc/scripts/checkpatch.pl
===================================================================
--- linux-2.6.27-misc.orig/scripts/checkpatch.pl
+++ linux-2.6.27-misc/scripts/checkpatch.pl
@@ -1513,6 +1513,7 @@ sub process {
if|for|while|switch|return|case|
volatile|__volatile__|
__attribute__|format|__extension__|
+ ([ph]?list_)?for_each_[a-z_]+|
asm|__asm__)$/x)
{


\
 
 \ /
  Last update: 2008-10-24 13:53    [W:0.062 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site