lkml.org 
[lkml]   [2008]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Handle space after for_each_* macros gracefully in checkpatch
On Fri, Oct 24, 2008 at 01:50:10PM +0200, Andi Kleen wrote:
> Handle space after for_each_* macros gracefully in checkpatch.pl
>
> Anyone else seeing the irony of checkpatch.pl recommending to
> use for_each_cpu_mask, but then not actually parsing it
> correctly.
>
> When you write
>
> for_each_cpu_mask (...) {
>
> it would complain about the space between mask and the open bracket
> because it thinks it's a normal function call.
>
> Fix this in a generic way. In theory someone could construct
> a normal function that starts with for_each_* and it would
> not warn, but I think that would be uncommon. The alternative
> of listing all macros was tried first, but turned out to
> be unwieldly.
>
> I think I covered most of the common ones available, the
> only exceptions are a few oddballs with leading prefix
> like pnp_for_each* or zorro_for_each.

I am happy with this conceptually. However when this was suggested
before there was a concensus that that it was not obvious whether this
was meant to be written as a function or a control and nothing was done.

So if people are with you on this, I am happy.

-apw


\
 
 \ /
  Last update: 2008-10-24 16:25    [W:0.025 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site