Messages in this thread | | | Date | Wed, 19 Dec 2007 11:40:33 +0800 | From | Herbert Xu <> | Subject | Inline local_bh_disable when TRACE_IRQFLAGS |
| |
Hi Ingo:
I noticed that local_bh_disable is now always out-of-line. The change was made when TRACE_IRQFLAGS was added. However, with TRACE_IRQFLAGS off, local_bh_disable does exactly the same work as before. In particular, it does pretty much the same as what preempt_disable does and the latter is always inline.
So I'm wondering if it would be reasonable to make it out-of-line when TRACE_IRQFLAGS is off. This may make a difference because the networking stack is a frequent user of local_bh_disable and local_bh_enable.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |