lkml.org 
[lkml]   [2007]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Inline local_bh_disable when TRACE_IRQFLAGS

* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> Hi Ingo:
>
> I noticed that local_bh_disable is now always out-of-line. The change
> was made when TRACE_IRQFLAGS was added. However, with TRACE_IRQFLAGS
> off, local_bh_disable does exactly the same work as before. In
> particular, it does pretty much the same as what preempt_disable does
> and the latter is always inline.
>
> So I'm wondering if it would be reasonable to make it out-of-line when
> TRACE_IRQFLAGS is off. This may make a difference because the
> networking stack is a frequent user of local_bh_disable and
> local_bh_enable.

do you mean to make it inline again?

(btw., generally i think local_bh_disable() is a poor API because it is
opaque about the data structure dependency that it governs. Explicit
exclusion rules generally work better.)

Ingo


\
 
 \ /
  Last update: 2007-12-19 12:35    [W:0.108 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site