Messages in this thread | | | Date | Mon, 19 Nov 2007 23:59:44 -0800 (PST) | Subject | Re: [PATCHv4 5/6] Allow setting O_NONBLOCK flag for new sockets | From | David Miller <> |
| |
From: Ulrich Drepper <drepper@redhat.com> Date: Tue, 20 Nov 2007 01:53:14 -0500
FWIW, I think this indirect syscall stuff is the most ugly interface I've ever seen proposed for the kernel.
And I agree with all of the objections raised by both H. Pater Anvin and Eric Dumazet.
> This patch adds support for setting the O_NONBLOCK flag of the file > descriptors returned by socket, socketpair, and accept. ... > - err = sock_attach_fd(sock1, newfile1); > + err = sock_attach_fd(sock1, newfile1, > + INDIRECT_PARAM(file_flags, flags));
Where does this INDIRECT_PARAM() macro get defined? I do not see it being defined anywhere in these patches.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |