Messages in this thread | | | Date | Sat, 17 Nov 2007 20:42:40 +0100 | From | Sam Ravnborg <> | Subject | Re: [patch] Printk kernel version in WARN_ON |
| |
On Sat, Nov 17, 2007 at 11:35:01AM -0800, Arjan van de Ven wrote: > On Sat, 17 Nov 2007 10:46:52 -0800 > Andrew Morton <akpm@linux-foundation.org> wrote: > > > > by ... not too much at least, gcc ought to be quite good at merging > > > same-strings into one, so it's just one extra pointer argument > > > > > > > I think I knew that. At 1000 callsites. > > ok so how about putting the same into dump_stack() instead? (see below) > added bonus is that it's now present for all dumps that use > dump_stack(), not just WARN_ON() > (the format I copied from the exact line used by oopses)
This solved the "zillion files being rebuild" issue I mentioned. So from that angle it is better.
And I notice you use the namespace aware helpers to access the kernelrelease string - I assume this is better than direct use of UTS_RELEASE.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |